Skip to content

server: control honouring internal IDs by old APIs#11976

Open
shwstppr wants to merge 1 commit intoapache:mainfrom
shapeblue:controluse-api-internalids
Open

server: control honouring internal IDs by old APIs#11976
shwstppr wants to merge 1 commit intoapache:mainfrom
shapeblue:controluse-api-internalids

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 4, 2025

Description

Fixes #9684

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
server: control honouring internal IDs by old APIs
77edb37 
Fixes apache#9684

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.57%. Comparing base (bfc4f60) to head (77edb37).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ava/com/cloud/api/dispatch/ParamProcessWorker.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11976   +/-   ##
=========================================
  Coverage     17.56%   17.57%           
- Complexity    15540    15547    +7     
=========================================
  Files          5909     5909           
  Lines        529045   529057   +12     
  Branches      64615    64618    +3     
=========================================
+ Hits          92933    92959   +26     
+ Misses       425657   425641   -16     
- Partials      10455    10457    +2
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm (as said on the issue, we can expand on it but good as is)

@shwstppr shwstppr marked this pull request as ready for review November 6, 2025 09:11
@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 30, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 30, 2026

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 30, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16647

@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 30, 2026
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 30, 2026

@nvazquez can you check/review?

@DaanHoogland DaanHoogland requested a review from nvazquez January 30, 2026 10:17
@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 31, 2026

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 31, 2026

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 1, 2026

[SF] Trillian test result (tid-15345)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55576 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11976-t15345-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 5.20 test_diagnostics.py
ContextSuite context=TestListIdsParams>:teardown Error 1.14 test_list_ids_parameter.py
test_01_snapshot_root_disk Error 4.84 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 49.63 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 49.63 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown Error 32.50 test_snapshots.py
test_01_snapshot_usage Error 25.76 test_usage.py
test_01_vpn_usage Error 1.09 test_usage.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

[API] Internal DB IDs used as parameters

3 participants

@shwstppr @blueorangutan @DaanHoogland

Comments